Skip to content

samples: settings: cleanup and use filters #86479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

samples: settings: cleanup and use filters #86479

merged 1 commit into from
Mar 7, 2025

Conversation

@nashif
Copy link
Member

@nashif nashif commented Feb 28, 2025 •
edited
Loading

an attempt to improve filter and configuration of the sample.

@nashif nashif mentioned this pull request Feb 28, 2025
Closed
@nordic-segl
Copy link
Contributor

nordic-segl commented Feb 28, 2025 •
edited
Loading

Coarse pull to Nordic's downstream:
nrfconnect/sdk-zephyr#2566
Proposed solution seems to be working on Nordic boards:

14:46:03  INFO    - 1/3 [email protected]/nrf54h20/cpuppr samples/subsys/settings/sample.subsys.settings     FILTERED (runtime filter)
14:46:03  INFO    - 2/3 [email protected]/nrf54h20/cpurad samples/subsys/settings/sample.subsys.settings     FILTERED (runtime filter)
14:47:07  INFO    - 3/3 [email protected]/nrf54h20/cpuapp samples/subsys/settings/sample.subsys.settings     PASSED (device: 1051111246, 7.117s <zephyr>)

[executed on more platforms than current platform_allow list]
14:46:41  INFO    -  1/11 nrf54l15dk/nrf54l15/cpuflpr samples/subsys/settings/sample.subsys.settings     FILTERED (runtime filter)
14:47:41  INFO    -  2/11 nrf5340dk/nrf5340/cpunet  samples/subsys/settings/sample.subsys.settings     PASSED (device: 1050082442, 7.982s <zephyr>)
14:47:41  INFO    -  3/11 nrf5340dk/nrf5340/cpuapp  samples/subsys/settings/sample.subsys.settings     PASSED (device: 1050076668, 7.997s <zephyr>)
14:47:41  INFO    -  4/11 [email protected]/nrf9160  samples/subsys/settings/sample.subsys.settings     PASSED (device: 960096840, 8.054s <zephyr>)
14:47:41  INFO    -  5/11 nrf54l15dk/nrf54l10/cpuapp samples/subsys/settings/sample.subsys.settings     PASSED (device: 1057729773, 6.337s <zephyr>)
14:47:41  INFO    -  6/11 nrf54l15dk/nrf54l05/cpuapp samples/subsys/settings/sample.subsys.settings     PASSED (device: 1057730331, 6.693s <zephyr>)
14:47:41  INFO    -  7/11 nrf54l15dk/nrf54l15/cpuapp samples/subsys/settings/sample.subsys.settings     PASSED (device: 1057794583, 5.968s <zephyr>)
14:47:41  INFO    -  8/11 nrf52840dk/nrf52840       samples/subsys/settings/sample.subsys.settings     PASSED (device: 1050272802, 8.545s <zephyr>)
14:47:41  INFO    -  9/11 nrf52dk/nrf52832          samples/subsys/settings/sample.subsys.settings     PASSED (device: 1050308051, 8.589s <zephyr>)
14:47:41  INFO    - 10/11 nrf5340dk/nrf5340/cpuapp/ns samples/subsys/settings/sample.subsys.settings     PASSED (device: 1050073141, 7.376s <zephyr>)
14:47:42  INFO    - 11/11 [email protected]/nrf9160/ns samples/subsys/settings/sample.subsys.settings     PASSED (device: 960045505, 7.442s <zephyr>)

[definition of storage partition is missing]
14:53:49  INFO    - 1/1 nrf54l20pdk/nrf54l20/cpuapp samples/subsys/settings/sample.subsys.settings     FILTERED (runtime filter)

@nashif
samples: settings: cleanup and use filters
da97836 
Almost all overlays only enable NVS and SETTINGS_NVS, something that
should be enabled in sample directly. Remove all overlays and make the
sample more genenric.

Use filter on storage partition to enable testing the sample on more
plaforms.

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif force-pushed the topic/settings/sample_filter branch from e9077c0 to da97836 Compare March 3, 2025 11:55
@nashif nashif marked this pull request as ready for review March 3, 2025 12:28
@zephyrbot zephyrbot added area: Samples Samples area: Settings Settings subsystem labels Mar 3, 2025
@zephyrbot zephyrbot requested a review from kartben March 3, 2025 12:29
hakehuang
hakehuang approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@hakehuang hakehuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice example

@fabiobaltieri fabiobaltieri added this to the v4.2.0 milestone Mar 4, 2025
@kartben kartben merged commit 270c4e4 into zephyrproject-rtos:main Mar 7, 2025
21 checks passed
nordic-segl added a commit to nordic-segl/sdk-nrf that referenced this pull request Mar 10, 2025
@nordic-segl
manifest: update sdk-zephyr
0cc2b89 
Include
samples: subsys: settings: Enable test on nrf54L20 PDK
nrfconnect/sdk-zephyr#2402
zephyrproject-rtos/zephyr#86479
(zephyrproject-rtos/zephyr#83165)

Signed-off-by: Sebastian Głąb <[email protected]>
nordic-piks pushed a commit to nrfconnect/sdk-nrf that referenced this pull request Mar 10, 2025
@nordic-segl @nordic-piks
manifest: update sdk-zephyr
51c926b 
Include
samples: subsys: settings: Enable test on nrf54L20 PDK
nrfconnect/sdk-zephyr#2402
zephyrproject-rtos/zephyr#86479
(zephyrproject-rtos/zephyr#83165)

Signed-off-by: Sebastian Głąb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@hakehuang hakehuang hakehuang approved these changes

+1 more reviewer

@nordic-segl nordic-segl nordic-segl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kartben kartben

Labels

area: Samples Samples area: Settings Settings subsystem

Projects

None yet

Milestone

v4.2.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nashif @nordic-segl @kartben @hakehuang @fabiobaltieri @zephyrbot